This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add test for RoomNotificationState #7820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression test for element-hq/element-web#20859
dbkr
added
the
T-Task
turt2live
approved these changes
Feb 16, 2022
Comment on lines
+27
to
+28
| stubClient(); | ||
| const client = MatrixClientPeg.get(); |
There was a problem hiding this comment.
we should probably come up with a code style for tests - these should be in a beforeEach (or beforeAll depending on your scope), but we don't really have a consistent approach within our existing tests.
Will bring it up at another venue.
There was a problem hiding this comment.
Yeah, it seemed a bit presumptuous to assume that all the tests would want something when it was the only test in the file so far... probably exactly why we should have consistent best practices.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test for element-hq/element-web#20859
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr7820--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.